Skip to content

feat: simplify navigation, make reload work #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jamadeo merged 12 commits into from
Sep 6, 2025
Merged

feat: simplify navigation, make reload work #4498

jamadeo merged 12 commits into from
Sep 6, 2025

Conversation

@jamadeo
Copy link
Collaborator

@jamadeo jamadeo commented Sep 3, 2025 •
edited
Loading

Improve the handling of routing by mostly replacing window.location.* with the corresponding react-router hooks, and keep better track of what the URL should be. With this change, reloading (cmd/ctrl+R) should now mostly do the expected thing.

@jamadeo jamadeo changed the title use navigate() feat: improve route state (cmd+R does the expected thing) Sep 3, 2025
@jamadeo jamadeo changed the title feat: improve route state (cmd+R does the expected thing) feat: make the app reloadable when resuming sessions Sep 4, 2025
@jamadeo jamadeo requested a review from zanesq September 4, 2025 15:24
@zanesq
Copy link
Collaborator

zanesq commented Sep 4, 2025

Nice I think this might work better, can you open this so we can try in a .bundle app?

@jamadeo jamadeo marked this pull request as ready for review September 4, 2025 15:49
@jamadeo
Copy link
Collaborator Author

jamadeo commented Sep 4, 2025

.bundle

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

⚠️ Cannot proceed with operation

  • reviewDecision: skip_reviews
  • commitStatus: PENDING

Reviews are not required for this operation but CI checks must be passing in order to continue

@jamadeo
Copy link
Collaborator Author

jamadeo commented Sep 4, 2025

.bundle

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

macOS ARM64 Desktop App (Apple Silicon)

📱 Download macOS Desktop App (arm64, unsigned)

Instructions:
After downloading, unzip the file and drag the Goose.app to a location you prefer. The app is unsigned, so to run it run xattr -r -d com.apple.quarantine '/path/to/Goose.app' and then open the app

@zanesq
Copy link
Collaborator

zanesq commented Sep 4, 2025

Got this from the bundle on app launch do you see this? Could pull in main to get rid of the localstorage error but I suspect the real error is

Not allowed to load local resource: file:///Users/zane/Downloads/Goose%2059.app/Contents/Resources/app.asar/.vite/renderer/main_window/index.html/%23

image

@jamadeo
Copy link
Collaborator Author

jamadeo commented Sep 4, 2025

oh yeah that's definitely this change, the %23 is a url encoded hash, I'll fix that

@zanesq zanesq mentioned this pull request Sep 4, 2025
Closed
@jamadeo
Copy link
Collaborator Author

jamadeo commented Sep 4, 2025

.bundle

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

macOS ARM64 Desktop App (Apple Silicon)

📱 Download macOS Desktop App (arm64, unsigned)

Instructions:
After downloading, unzip the file and drag the Goose.app to a location you prefer. The app is unsigned, so to run it run xattr -r -d com.apple.quarantine '/path/to/Goose.app' and then open the app

@jamadeo
Copy link
Collaborator Author

jamadeo commented Sep 5, 2025

.bundle

@jamadeo jamadeo changed the title feat: make the app reloadable when resuming sessions feat: simplify navigation, make reload work Sep 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

macOS ARM64 Desktop App (Apple Silicon)

📱 Download macOS Desktop App (arm64, unsigned)

Instructions:
After downloading, unzip the file and drag the Goose.app to a location you prefer. The app is unsigned, so to run it run xattr -r -d com.apple.quarantine '/path/to/Goose.app' and then open the app

zanesq
zanesq approved these changes Sep 5, 2025
View reviewed changes
Copy link
Collaborator

@zanesq zanesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally and in the bundled app and refresh issue appears fixed!

@jamadeo jamadeo merged commit 7fb746b into main Sep 6, 2025
11 checks passed
@jamadeo jamadeo deleted the jackamadeo/set-url-state branch September 6, 2025 00:36
michaelneale added a commit that referenced this pull request Sep 8, 2025
@michaelneale
Merge branch 'main' into feat/unified-diff-support
8a07a0a 
* main:
  docs: social channels (#4552)
  feat: simplify navigation, make reload work (#4498)
  docs: new recipe warning (#4545)
  Add AGENTS.md for AI coding assistant support (#4539)
  docs: non-interactive compact now (#4543)
  fixed css classes and added some accessibility fixes (#4492)
  feat(acp): Read files (#4531)
  Add YouTube Short to Auto Visualiser Tutorial (#4536)
  Fix/settings page (#4520)
  update to RMCP 0.6.2 (#4523)
katzdave added a commit that referenced this pull request Sep 8, 2025
@katzdave
Merge branch 'main' of github.com:block/goose into dkatz/message-meta…
f0af7ab 
…data

* 'main' of github.com:block/goose:
  docs: add ampersand to link (#4560)
  Add video link to README for user guidance (#4553)
  docs: social channels (#4552)
  feat: simplify navigation, make reload work (#4498)
  docs: new recipe warning (#4545)
  Add AGENTS.md for AI coding assistant support (#4539)
  docs: non-interactive compact now (#4543)
  fixed css classes and added some accessibility fixes (#4492)
katzdave added a commit that referenced this pull request Sep 8, 2025
@katzdave
Merge branch 'main' of github.com:block/goose into dkatz/threshold-ui
728da16 
* 'main' of github.com:block/goose:
  docs: add ampersand to link (#4560)
  Add video link to README for user guidance (#4553)
  docs: social channels (#4552)
  feat: simplify navigation, make reload work (#4498)
  docs: new recipe warning (#4545)
  Add AGENTS.md for AI coding assistant support (#4539)
  docs: non-interactive compact now (#4543)
  fixed css classes and added some accessibility fixes (#4492)
  feat(acp): Read files (#4531)
  Add YouTube Short to Auto Visualiser Tutorial (#4536)
  Fix/settings page (#4520)
  update to RMCP 0.6.2 (#4523)
  docs: nested goosehints (#4528)
  feat: Agent Client Protocol implementation of goose (#4511)
  feat: make tests for rmcp based developer server consistent with former implementation (#4519)
  worlds simplest logging to see where things are blocked (#3888)
  docs: update quickstart and install topics (#4378)
  feat: Add configurable Bedrock retry parameters (#4316)
  remove localstorage getconfig fallbacks (#4432)
  chore(deps-dev): bump electron from 37.2.6 to 37.4.0 in /ui/desktop (#4516)
tiensi added a commit to tiensi/goose that referenced this pull request Sep 8, 2025
@tiensi
Merge branch 'main' into tiensi/add-download_cli_ps1-to-yml
9ea11bd 
* main: (43 commits)
  feat: add auto-compact threshold configuration UI (block#4178)
  Add container detection to developer extension (block#4559)
  docs: add ampersand to link (block#4560)
  Add video link to README for user guidance (block#4553)
  docs: social channels (block#4552)
  feat: simplify navigation, make reload work (block#4498)
  docs: new recipe warning (block#4545)
  Add AGENTS.md for AI coding assistant support (block#4539)
  docs: non-interactive compact now (block#4543)
  fixed css classes and added some accessibility fixes (block#4492)
  feat(acp): Read files (block#4531)
  Add YouTube Short to Auto Visualiser Tutorial (block#4536)
  Fix/settings page (block#4520)
  update to RMCP 0.6.2 (block#4523)
  docs: nested goosehints (block#4528)
  feat: Agent Client Protocol implementation of goose (block#4511)
  feat: make tests for rmcp based developer server consistent with former implementation (block#4519)
  worlds simplest logging to see where things are blocked (block#3888)
  docs: update quickstart and install topics (block#4378)
  feat: Add configurable Bedrock retry parameters (block#4316)
  ...
This was referenced Sep 9, 2025
Closed
Merged
thebristolsound pushed a commit to thebristolsound/goose that referenced this pull request Sep 11, 2025
@jamadeo
feat: simplify navigation, make reload work (block#4498)
68b2bbd 
Signed-off-by: Matt Donovan <[email protected]>
HikaruEgashira pushed a commit to HikaruEgashira/goose that referenced this pull request Oct 3, 2025
@jamadeo @HikaruEgashira
feat: simplify navigation, make reload work (block#4498)
233c670 
Signed-off-by: HikaruEgashira <[email protected]>
@Anudhyan Anudhyan mentioned this pull request Oct 5, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanesq zanesq zanesq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamadeo @zanesq